Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============4690627095044787574=="
MIME-Version: 1.0
Subject: Re: Review Request 14426: Tests for Netscaler support as external LB
 Provider in VPC
From: "Sowmya Krishnan" <sowmya.krishnan@citrix.com>
To: "Rajesh Battala" <rajesh.battala@citrix.com>,
 "Prasanna Santhanam" <tsp@apache.org>,
 "Santhosh Edukulla" <santhosh.edukulla@citrix.com>,
 "venkata swamy babu  budumuru" <venkataswamybabu.budumuru@citrix.com>
Cc: "Sowmya Krishnan" <sowmya.krishnan@citrix.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Tue, 15 Oct 2013 11:30:48 -0000
Message-ID: <20131015113048.7309.67144@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sowmya Krishnan" <noreply@reviews.apache.org>
References: <20131001062637.28587.5778@reviews.apache.org>
In-Reply-To: <20131001062637.28587.5778@reviews.apache.org>
Reply-To: "Sowmya Krishnan" <sowmya.krishnan@citrix.com>

--===============4690627095044787574==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14426/
-----------------------------------------------------------

(Updated Oct. 15, 2013, 11:30 a.m.)


Review request for cloudstack, Rajesh Battala, Santhosh Edukulla, venkata swamy babu  budumuru, and Prasanna Santhanam.


Bugs: CLOUDSTACK-4776


Repository: cloudstack-git


Description
-------

Created tests for Netscaler as external LB provider in VPC
Used ddt to achieve this without adding new tests but modifying the existing tests
Created new network_offering_vpcNS 
Handled addition on NS as optional in setup - if NS addition fails, the non-NS tests still work and NS tests alone will be skipped
Removed the creation of vpc Offering for each test, instead, using Default offering
test_03_create_network_netscaler is no more valid - removed it. I am adding new tests for NS as external LB provider. So this is not needed.


Diffs
-----

  test/integration/component/test_vpc_network.py 970a625 

Diff: https://reviews.apache.org/r/14426/diff/


Testing
-------

Tested script locally. Long running script... Latest run looks good so far. 

output so far:
Test create network in VPC ... ok
Test create network in VPC ... ok
Test create network in VPC mismatched services (Should fail) ... ok
Test create network in VPC mismatched services (Should fail) ... ok
Test create multiple networks with LB service (Should fail) ... ok
Test create multiple networks with LB service (Should fail) ... ok
Test create network with external LB devices ... ok
Test create network with redundant router capability ... SKIP: skipped - RvR didn't support VPC currently
Test create network services not supported by VPC (Should fail) ... ok
Test create network without sourceNAT service in VPC (should fail) ... ok
Test create network with shared network offering ... ok
Test create network with shared network offering ... ok
Test create network with conserve mode ON ... ok
Test create network with conserve mode ON ... ok
Test network gc after shutdown of vms in the network ... FAIL
Test network rules after starting a VpcVr that was shutdown after network.gc ... ok
Test Stop all the Vms that are part of the a Network ... ok
Test create network outside cidr range of VPC ... ok
Test create network outside cidr range of VPC ... ok
Test create network outside cidr range of VPC ... ok
Test create network inside cidr range of VPC ... ok
Test create network inside cidr range of VPC ... ok
Test create network overlapping cidr range of VPC ...


Thanks,

Sowmya Krishnan


--===============4690627095044787574==--