Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D367F107E4 for ; Thu, 10 Oct 2013 15:03:27 +0000 (UTC) Received: (qmail 69355 invoked by uid 500); 10 Oct 2013 15:03:26 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 69124 invoked by uid 500); 10 Oct 2013 15:03:25 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 69101 invoked by uid 99); 10 Oct 2013 15:03:24 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Oct 2013 15:03:24 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of Chris.Suich@netapp.com designates 216.240.18.76 as permitted sender) Received: from [216.240.18.76] (HELO mx11.netapp.com) (216.240.18.76) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Oct 2013 15:03:19 +0000 X-IronPort-AV: E=Sophos;i="4.90,1072,1371106800"; d="scan'208";a="58402035" Received: from vmwexceht06-prd.hq.netapp.com ([10.106.77.104]) by mx11-out.netapp.com with ESMTP; 10 Oct 2013 08:02:54 -0700 Received: from SACEXCMBX01-PRD.hq.netapp.com ([169.254.2.51]) by vmwexceht06-prd.hq.netapp.com ([10.106.77.104]) with mapi id 14.03.0123.003; Thu, 10 Oct 2013 08:02:54 -0700 From: "SuichII, Christopher" To: "" Subject: Re: [PROPOSAL] Remove Setters from *JoinVO Thread-Topic: [PROPOSAL] Remove Setters from *JoinVO Thread-Index: AQHOwSdVNZyHCby5iUi0oxPYuVmU0Zns7iGAgAGYfAA= Date: Thu, 10 Oct 2013 15:02:53 +0000 Message-ID: <08B7C9B4-EE37-43D0-8AE6-E12E723D048C@netapp.com> References: <66BA287E-E54A-47B1-85D7-F43F68766C7E@netapp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.106.53.51] Content-Type: text/plain; charset="Windows-1252" Content-ID: <6E6B8041FA50D843AD4BD4463F9AD641@hq.netapp.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org I went ahead and removed all setters from *JoinVOs this morning and played = around in my environment. There were no compile errors since nobody called = those setters, everything seems to be working just fine and there aren't an= y errors in any of the logs. Does anyone have any suggestions on how to properly test this? I can't imag= ine we're using Java reflection somewhere to actually invoke the setter for= a given field. Other than that, with no compile errors, I don't see this c= ausing any issues. -Chris --=20 Chris Suich chris.suich@netapp.com NetApp Software Engineer Data Center Platforms =96 Cloud Solutions Citrix, Cisco & Red Hat On Oct 10, 2013, at 1:40 AM, Koushik Das wrote: > Views are meant to be read only. So +1 for removing setters. >=20 > On 04-Oct-2013, at 10:59 PM, "SuichII, Christopher" wrote: >=20 >> *JoinVOs are used to store entries from MySQL views, which are not edita= ble. I think removing setters from the *JoinVOs may help avoid some potenti= al confusion as setters seem to imply that the fields are editable, which t= hey really aren't. >>=20 >> I started looking around and it looks like most setters in *JoinVOs aren= 't actually used since the creation of *VOs is handled by java reflection. = Please let me know if this is not the case or if I'm misunderstanding the w= ay the MySQL views work. >>=20 >> -Chris >> --=20 >> Chris Suich >> chris.suich@netapp.com >> NetApp Software Engineer >> Data Center Platforms =96 Cloud Solutions >> Citrix, Cisco & Red Hat >>=20 >=20