cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nitin Mehta <Nitin.Me...@citrix.com>
Subject Re: questions about registerIso API and updateIsoPermissions API
Date Wed, 09 Oct 2013 21:07:39 GMT
I think (1) is the right way to go.

From: Jessica Wang <Jessica.Wang@citrix.com<mailto:Jessica.Wang@citrix.com>>
Date: Wednesday 9 October 2013 12:47 PM
To: Nitin Mehta <nitin.mehta@citrix.com<mailto:nitin.mehta@citrix.com>>, "<dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>>"
<dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>>, Alena Prokharchyk
<Alena.Prokharchyk@citrix.com<mailto:Alena.Prokharchyk@citrix.com>>
Cc: Shweta Agarwal <Shweta.Agarwal@citrix.com<mailto:Shweta.Agarwal@citrix.com>>
Subject: RE: questions about registerIso API and updateIsoPermissions API

Currently, at API level, a normal user is not allowed to specify “isfeatured” when registering
ISO (API will ignore “isfeatured” parameter when a normal user passes it),
but a normal user is allowed to specify “isfeatured” when updating ISO.

Should we fix API to:
(1) allow a normal user to specify “isfeatured” when registering ISO (API won’t ignore
“isfeatured” parameter when a normal user passes it)

OR

(2) disallow a normal user to specify “isfeatured” when updating ISO

?


p.s. I’ll do corresponding UI change after API is fixed.


From: Jessica Wang
Sent: Wednesday, October 09, 2013 11:01 AM
To: Nitin Mehta; <dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>>
Cc: Alena Prokharchyk; Shweta Agarwal
Subject: RE: questions about registerIso API and updateIsoPermissions API

Nitin,

>  At the moment, I think that for Isos we should allow to edit it so would call it an
API bug.
Thanks.

> Register Iso does provide an option to mark an ISO featured. I see that in the latest
master.
That only works for admin, but NOT normal user.

If you log in as a normal user, then pass “isfeatured=true” to registerIso API, API will
ignore it.
The newly registered template will have “isfeatured: false”.

e.g.
http://10.215.3.26:8080/client/api?command=registerIso&response=json&sessionkey=u%2FVIHPJuPohidGKFd0lh6csG%2BfM%3D&name=normalUserIso1&displayText=normalUserIso1&url=http%3A%2F%2F10.223.110.231%2Fisos_64bit%2Fdummy.iso&zoneid=6bcd3bd9-591c-4d99-a164-d05b87df1b04&isfeatured=true&isextractable=false&bootable=true&osTypeId=b8cbfd6c-2d40-11e3-86aa-3c970e739c3e&ispublic=false&_=1381340961641
{
    "registerisoresponse": {
        "count": 1,
        "iso": [
            {
                "id": "9b903876-f17c-4634-8463-8e3025259956",
                "name": "normalUserIso1",
                "displaytext": "normalUserIso1",
                "ispublic": false,
                "created": "2013-10-09T10:52:38-0700",
                "isready": false,
                "bootable": true,
                "isfeatured": false,
                "crossZones": false,
                "ostypeid": "b8cbfd6c-2d40-11e3-86aa-3c970e739c3e",
                "ostypename": "Apple Mac OS X 10.6 (32-bit)",
                "account": "aaa_user",
                "zoneid": "6bcd3bd9-591c-4d99-a164-d05b87df1b04",
                "zonename": "jw-adv",
                "status": "",
                "domain": "aaa",
                "domainid": "47b09d73-84ef-48dc-9b73-1720bad600cb",
                "isextractable": false,
                "tags": []
            }
        ]
    }
}

Jessica

From: Nitin Mehta
Sent: Tuesday, October 08, 2013 5:27 PM
To: Jessica Wang; <dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>>
Cc: Alena Prokharchyk; Shweta Agarwal
Subject: Re: questions about registerIso API and updateIsoPermissions API

Answers inline.

From: Jessica Wang <Jessica.Wang@citrix.com<mailto:Jessica.Wang@citrix.com>>
Date: Tuesday 8 October 2013 5:10 PM
To: "<dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>>" <dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>>
Cc: Alena Prokharchyk <Alena.Prokharchyk@citrix.com<mailto:Alena.Prokharchyk@citrix.com>>,
Nitin Mehta <nitin.mehta@citrix.com<mailto:nitin.mehta@citrix.com>>, Shweta Agarwal
<Shweta.Agarwal@citrix.com<mailto:Shweta.Agarwal@citrix.com>>
Subject: questions about registerIso API and updateIsoPermissions API

Hi,

I have questions about registerIso API and updateIsoPermissions API.

(1) A normal user is allowed to specify isextractable property when registering an ISO (through
registerIso API),
but NOT allowed to update isextractable property when updating an ISO (through updateIsoPermissions
API).
Is this by design or it's just an API bug?

Nitin>> This is a grey area. This was done for templates (Isos just inherited it) because
derived templates may or may not belong to the same user and we want to follow the principle
of least privilege.
At the moment, I think that for Isos we should allow to edit it so would call it an API bug.

(2) A normal user is NOT allowed to specify isfeatured property when registering an ISO (through
registerIso API),
but allowed to update isfeatured property when updating an ISO (through updateIsoPermissions
API)?
Is this by design or it's just an API bug?

Nitin>> Register Iso does provide an option to mark an ISO featured. I see that in the
latest master.

Jessica

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message