cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Laszlo Hornyak <laszlo.horn...@gmail.com>
Subject Re: Review Request 14577: Remove Setters from *JoinVO Classes
Date Sun, 13 Oct 2013 19:00:52 GMT
Hi,

I tested it yesterday and it looked like working correctly. My only concern
about it is that I am not sure if this is still compatible with standard
JPA, However this may not be an important point since CS does not really
build on standard JPA. I would be interested in any info in the plans for
persistence topic anyone want to share :)



On Sun, Oct 13, 2013 at 8:43 PM, Daan Hoogland <daan.hoogland@gmail.com>wrote:

> Chris,
>
> have you been discussing this with anybody? I think you should include
> those people in the reviewers list to get feedback. I would have to
> find some time to play around with it, though it looks ok on first
> glance.
>
> regards,
> Daan
>
> On Fri, Oct 11, 2013 at 9:33 PM, SuichII, Christopher
> <Chris.Suich@netapp.com> wrote:
> > Just bumping this. It should be a fairly simple review.
> >
> > --
> > Chris Suich
> > chris.suich@netapp.com<mailto:chris.suich@netapp.com>
> > NetApp Software Engineer
> > Data Center Platforms – Cloud Solutions
> > Citrix, Cisco & Red Hat
> >
> > On Oct 10, 2013, at 1:04 PM, Chris Suich <Chris.Suich@netapp.com<mailto:
> Chris.Suich@netapp.com>> wrote:
> >
> > This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14577/
> >
> > Review request for cloudstack.
> > By Chris Suich.
> > Repository: cloudstack-git
> > Description
> >
> > Removed setters from all *JoinVO classes as they represent MySQL views
> which are not editable.
> >
> > The one exception to this was that I left setPassword(String) in
> UserVmJoinVO. This is because the view does not actually have the user's
> password, but it is a field in UseVmJoinVO, so it must be set manually, not
> auto-populated from the DB.
> >
> >
> > Testing
> >
> > There were no compile errors after the deletions, so there shouldn't be
> any issues.
> >
> > However, I did do a clean build and played around with the UI while
> watching vmops.log to make sure there were no errors being thrown over this.
> >
> >
> > Diffs
> >
> >   *   server/src/com/cloud/api/query/vo/AccountJoinVO.java (fbcc934)
> >   *   server/src/com/cloud/api/query/vo/AffinityGroupJoinVO.java
> (ae63a8a)
> >   *   server/src/com/cloud/api/query/vo/AsyncJobJoinVO.java (c45be1c)
> >   *   server/src/com/cloud/api/query/vo/BaseViewVO.java (6b1ddd6)
> >   *   server/src/com/cloud/api/query/vo/DataCenterJoinVO.java (c6a80e7)
> >   *   server/src/com/cloud/api/query/vo/DiskOfferingJoinVO.java (58e8370)
> >   *   server/src/com/cloud/api/query/vo/DomainRouterJoinVO.java (bfe4486)
> >   *   server/src/com/cloud/api/query/vo/EventJoinVO.java (12d7e5a)
> >   *   server/src/com/cloud/api/query/vo/HostJoinVO.java (cf3cfdc)
> >   *   server/src/com/cloud/api/query/vo/ImageStoreJoinVO.java (ac161af)
> >   *   server/src/com/cloud/api/query/vo/InstanceGroupJoinVO.java
> (3fb4309)
> >   *   server/src/com/cloud/api/query/vo/ProjectAccountJoinVO.java
> (1a8818a)
> >   *   server/src/com/cloud/api/query/vo/ProjectInvitationJoinVO.java
> (f6e6760)
> >   *   server/src/com/cloud/api/query/vo/ProjectJoinVO.java (3885fa0)
> >   *   server/src/com/cloud/api/query/vo/ResourceTagJoinVO.java (9ce9555)
> >   *   server/src/com/cloud/api/query/vo/SecurityGroupJoinVO.java
> (258b613)
> >   *   server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java
> (05ff5f3)
> >   *   server/src/com/cloud/api/query/vo/StoragePoolJoinVO.java (d98bb3b)
> >   *   server/src/com/cloud/api/query/vo/TemplateJoinVO.java (bb1cfed)
> >   *   server/src/com/cloud/api/query/vo/UserAccountJoinVO.java (c44027b)
> >   *   server/src/com/cloud/api/query/vo/UserVmJoinVO.java (745db56)
> >   *   server/src/com/cloud/api/query/vo/VolumeJoinVO.java (9fe9fd1)
> >
> > View Diff<https://reviews.apache.org/r/14577/diff/>
> >
> >
>



-- 

EOF

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message