cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ian Duffy <...@ianduffy.ie>
Subject Re: UI accounts wizard broken
Date Sat, 12 Oct 2013 12:24:33 GMT
>
> Generally, I'm thinking writing in a custom widget should only be for if a
> special layout or visual flow is needed -- i.e., like a dashboard or wizard
> with a unique layout, so moving forward if the standard process needs more
> checks or conditionals, we can first see if the UI toolkit can be expanded
> easily to support it.


That sounds like a much nicer/cleaner solution.

I'll file a bug for the password confirm not working...


Is there a reason why the following snippet of code doesn't provide
equality between the two password fields?

https://gist.github.com/imduffy15/6949448




On 11 October 2013 18:21, Brian Federle <Brian.Federle@citrix.com> wrote:

> No worries, I must have missed the original discussion.
>
> Probably an easier way would be to add support for passing a closure to
> the createForm: and/or add: action block, so you can conditionally check
> context and return the appropriate form. We can modify the account form to
> use this in the future, but for now as long as the dialog works then it is
> OK, I was able to hack around the styling issues.
>
> Generally, I'm thinking writing in a custom widget should only be for if a
> special layout or visual flow is needed -- i.e., like a dashboard or wizard
> with a unique layout, so moving forward if the standard process needs more
> checks or conditionals, we can first see if the UI toolkit can be expanded
> easily to support it.
>
> I'll file a bug for the password confirm not working...
>
> Thanks,
> Brian
> ________________________________________
> From: Ian Duffy [ian@ianduffy.ie]
> Sent: Thursday, October 10, 2013 7:23 PM
> To: Jessica Wang; Abhinandan Prateek; Pranav Saxena
> Cc: Brian Federle; dev@cloudstack.apache.org; Animesh Chaturvedi; Sonny
> Chhen
> Subject: Re: UI accounts wizard broken
>
> Hi Brian,
>
> > I noticed that the 'add account' dialog was changed substantially, and
> converted to a custom UI widget. Additionally, the password
> > confirm field validation is broken, so I am unable to add a new account
>
> The change was made in order to allow the wizard to change to include
> a list of users grabbed from LDAP when LDAP is enabled. This was done
> in order to aid ease of user provisioning.
>
> The change was discussed some time ago on the mailing list:
> Switch dialog actions based on result from API call. -
> http://markmail.org/thread/ebtm2iqzvz3sm3ne
> UI Query: Create Form - http://markmail.org/thread/kcngmhlgxeukvscb
>
> Based on the replies from Jessica and Pranav the only way to go about
> implementing this was via the custom widget.
>
> > This doesn't seem to really need something custom from the looks of it
>
> Is there a way we can use createForm and still implement the custom
> dialog ( http://ianduffy.ie/cloudstack/screen1.png ) when Ldap is
> enabled?
>
> Very sorry about this! Wasn't aware such issue was present.
>
> Thanks,
> Ian
>
> On 10 October 2013 21:03, Jessica Wang <Jessica.Wang@citrix.com> wrote:
> > +1
> >
> > -----Original Message-----
> > From: Brian Federle
> > Sent: Thursday, October 10, 2013 12:55 PM
> > To: dev@cloudstack.apache.org
> > Cc: Animesh Chaturvedi; Jessica Wang; Sonny Chhen
> > Subject: RE: UI accounts wizard broken
> >
> > Also, I am referring to this commit. I do not remember any active UI
> comitters including myself receiving a review request for this...
> >
> > commit eaa41433715ba1a1137ad9f346ea8569e31e4560
> > Author: Ian Duffy <ian@ianduffy.ie>
> > Date:   Thu Jul 25 10:24:13 2013 +0100
> >
> >     Merge LDAPPlugin
> >
> >     Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
> >
> > -----Original Message-----
> > From: Brian Federle [mailto:Brian.Federle@citrix.com]
> > Sent: Thursday, October 10, 2013 12:46 PM
> > To: dev@cloudstack.apache.org
> > Cc: Animesh Chaturvedi; Jessica Wang; Sonny Chhen
> > Subject: UI accounts wizard broken
> >
> > After reviewing the UI on the latest master, I noticed that the 'add
> account' dialog was changed substantially, and converted to a custom UI
> widget. Additionally, the password confirm field validation is broken, so I
> am unable to add a new account.
> >
> > Can I know the reason this was converted to a custom widget, instead of
> using the standard createForm? This doesn't seem to really need something
> custom from the looks of it. I am mainly concerned since it is causing
> validation bugs as well as some display glitches, which could be avoided by
> using the standard widget toolkit.
> >
> > Thanks,
> > Brian
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message