cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anshul Gangwar <anshul.gang...@citrix.com>
Subject RE: Review Request 14827: hyperv unit tests
Date Tue, 29 Oct 2013 04:28:18 GMT
Hi Donal,

We don't have to give -DskipTests=false specifically. They will be triggered by default i.e.

mvn clean install -P hyperv-agent 

will also trigger the C# unit tests.

Thanks,
Anshul

-----Original Message-----
From: Donal Lafferty 
Sent: Monday, October 28, 2013 4:58 PM
To: dev@cloudstack.apache.org; Prasanna Santhanam; Rajesh Battala; Devdeep Singh; Chiradeep
Vittal
Cc: Anshul Gangwar
Subject: RE: Review Request 14827: hyperv unit tests

The mvn build flags are:

-P hyperv-plugin for the C# portion of plugin -DskipTests=false for unit tests (platform independent
tests) -DskipFunctionalTests=false for functional tests (tests that need to be run on a Hyper-V
server)

Setup for Mono is on the blog: http://dlafferty.blogspot.co.uk/2013/08/building-your-microsoft-solution-with.html

I will update the Building the Agent section https://cwiki.apache.org/confluence/display/CLOUDSTACK/Progress
with these details


DL


> -----Original Message-----
> From: Prasanna Santhanam [mailto:noreply@reviews.apache.org] On Behalf 
> Of Prasanna Santhanam
> Sent: 28 October 2013 11:20
> To: Rajesh Battala; Donal Lafferty; Devdeep Singh; Chiradeep Vittal
> Cc: Prasanna Santhanam; Anshul Gangwar; cloudstack
> Subject: Re: Review Request 14827: hyperv unit tests
> 
> 
> 
> > On Oct. 28, 2013, 8:25 a.m., Prasanna Santhanam wrote:
> > > Are we okay with putting in VisualStudio project files? We don't 
> > > do the
> same for Eclipse.
> > > +
> plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentShell
> .csproj
> > >
> > > I guess there is a HOWTO somewhere on running the NUnit tests?
> > >
> > > Also, isn't .vhdx a binary file?
> >
> > Prasanna Santhanam wrote:
> >     May be the .vhdx should contain a ASF license header. It seems 
> > to be a
> dummy file.
> >
> > Donal Lafferty wrote:
> >     Hi Prasanna,
> >
> >     VisualStudio's .sln and .csproj files provide functionality 
> > equivalent to
> Maven's pom.xml  User specific settings are in a .suo file along side 
> the .sln, but this has not been included in the diff.
> >
> >     WRT running the NUnit tests, they are triggered automatically as 
> > part of
> the hyperv-plugin profile.  Should we add a README.txt?
> >
> >     The .vhdx is a dummy file used in functional tests.  It may be 
> > worth
> considering downloading this separate to source, as we do with the 
> system VM templates.
> >
> >     My 2cents...
> >
> > Anshul Gangwar wrote:
> >     I will remove the .vhdx file and will create the file for test 
> > dynamically
> >
> >     As Donal mentioned NUnit tests will be triggered automatically 
> > as part of
> the hyperv-plugin profile. skipTests switch is used to trigger 
> them/skip them
> 
> Understood. I was looking for build instructions for the C# files. Is 
> this covered on your blog?
> 
> 
> - Prasanna
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14827/#review27604
> -----------------------------------------------------------
> 
> 
> On Oct. 23, 2013, 11:05 a.m., Anshul Gangwar wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/14827/
> > -----------------------------------------------------------
> >
> > (Updated Oct. 23, 2013, 11:05 a.m.)
> >
> >
> > Review request for cloudstack, Chiradeep Vittal, Devdeep Singh, 
> > Donal
> Lafferty, and Rajesh Battala.
> >
> >
> > Repository: cloudstack-git
> >
> >
> > Description
> > -------
> >
> > Hyperv Unit tests written using NSubstitute and XUnit. Description 
> > for this
> can be found at
> >
> > http://nsubstitute.github.io/help/getting-started/
> > http://xunit.codeplex.com/wikipage?title=HowToUse
> > http://xunit.codeplex.com/wikipage?title=Comparisons
> >
> > Currently packages have to be manually copied for Linux. buildagent 
> > script
> is not downloading them.
> >
> > I have also changed the existing tests to xunit
> >
> >
> > Diffs
> > -----
> >
> >   plugins/hypervisors/hyperv/DotNet/ServerResource/.gitignore 
> > cf9cb85
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/NuGet.Config
> PRE-CREATION
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/NuGet.targets
> PRE-CREATION
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentSetti
> ngs.Designer.cs a73e6bb
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentSetti
> ngs.settings 435b8e0
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentShell
> .csproj fe055d0
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/packages.c
> onfig f5f47e6
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Hype
> rvResource.csproj dbd7b15
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Hype
> rvResourceController.cs 7a0c2db
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/IWmi
> Calls.cs PRE-CREATION
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/IWmi
> CallsV2.cs PRE-CREATION
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Wmi
> Calls.cs 1b9e073
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Wmi
> CallsV2.cs 7557320
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/pack
> ages.config b0f2ace
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/
> App.config 1bf17d4
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/
> HypervResourceController1Test.cs PRE-CREATION
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/
> HypervResourceControllerTest.cs 8a86727
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/
> ServerResource.Tests.csproj 381245e
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/
> packages.config 08ef691
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/WmiWr
> appers.csproj d3baab4
> >   plugins/hypervisors/hyperv/buildagent.sh f2a4921
> >
> plugins/hypervisors/hyperv/var/test/storagepool/TestCopiedLocalTemplate.
> vhdx PRE-CREATION
> >
> > Diff: https://reviews.apache.org/r/14827/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Anshul Gangwar
> >
> >

Mime
View raw message