cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hugo Trippaers <>
Subject Re: [MERGE] txn-refactor
Date Thu, 17 Oct 2013 07:04:19 GMT
Hey Darren,

I'm having a look at the branch. Takes some time so i will get back to you when i have something.

Did you run the bvt test suite on this branch already?



On Oct 16, 2013, at 6:59 PM, Darren Shepherd <> wrote:

> I need as many people as possible to review this branch.  I'm still
> testing it out, but I wanted to get as many eyes on it as possible.
> This is a huge cross cutting change.  This branch is the changes to
> use a new Transaction API that will be consistent Spring TX's style so
> that we can eventually move to it.  You can get a bit more context
> from
> Having spent so much time looking at the transaction management in
> ACS, I'm well convinced we need to adopt Spring TX as soon as we can.
> I've found just too many bugs.  It will be a painful transitiion, as
> you can see from this branch.  It will also be very tricky, but I'll
> figure it out.
> If you are reviewing this branch, use a diff tool that ignores
> whitespace.  Also if you don't know about "git difftool -d", you
> should use that.  Just know, its was 10x more tedious and painful for
> me to make this change then it is for you to review it :)
> Darren

View raw message