cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Hornyak" <laszlo.horn...@gmail.com>
Subject Re: Review Request 15108: Grab MacAddress in a more deterministic fashion
Date Thu, 31 Oct 2013 08:29:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15108/#review27875
-----------------------------------------------------------


I haven't had a chance to test it yet, but I prefer this solution over my own patchset, since
I was only trying to fix some broken functionality without radically changing the behavior.
One minor problem I see in there is that still lots of code in static initializer block, it
is hard to write unit tests for it. I think we can solve that later.

- Laszlo Hornyak


On Oct. 31, 2013, 12:18 a.m., Darren Shepherd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15108/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 12:18 a.m.)
> 
> 
> Review request for cloudstack, Alex Huang and Laszlo Hornyak.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The MAC address is determined in the following order
> 
> 1. Look for MAC that matches interface of cluster.node.IP
> 2. Look for first interface alphabetically that has a non-linklocal address
> 3. Look for first interface alphabetically
> 4. Randomly generate a mac address
> 
> 
> Diffs
> -----
> 
>   utils/src/com/cloud/utils/net/MacAddress.java 15350c8 
> 
> Diff: https://reviews.apache.org/r/15108/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Darren Shepherd
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message