cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Toshiaki Hatano" <hae...@haeena.net>
Subject Re: Review Request 14868: CLOUDSTACK-4932: Bugfix: listNetworks API doesn't return vlan id / VNI ( Virtual Network Identifier in VXLAN )
Date Wed, 30 Oct 2013 15:37:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14868/#review27780
-----------------------------------------------------------

Ship it!


Ship It!

- Toshiaki Hatano


On Oct. 23, 2013, 6:38 a.m., Yoshikazu Nojima wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14868/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 6:38 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo
Trippaers, and Toshiaki Hatano.
> 
> 
> Bugs: CLOUDSTACK-4932
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4932
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Issue to resolve:
> When listNetworks API is called with root admin account, it must return vlan id, but
it returns "N/A".
> I tested with the branch "master".
> 
> http://cloudstack.apache.org/docs/api/apidocs-4.2/root_admin/listNetworks.html
> 
> This patch fixed comparison bug of BroadCastDomainType instance to make this api return
vlan id, and made this api returns VNI ( Virtual Network Identifier in VXLAN ) when network
is configured to use VXLAN.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/ApiResponseHelper.java f4ca112 
> 
> Diff: https://reviews.apache.org/r/14868/diff/
> 
> 
> Testing
> -------
> 
> I confirmed appropriate VLAN ID is returned by listNetworks API, and it is displayed
in the "Network"/"Guest networks"/"details" tab in CloudStack WebGUI.
> 
> 
> Thanks,
> 
> Yoshikazu Nojima
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message