cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Sorensen" <shadow...@gmail.com>
Subject Re: Review Request 15001: CLOUDSTACK-4967: Bugfix: Guest network isn't created correctly in rare case when vxlan is used for isolation method
Date Tue, 29 Oct 2013 10:16:15 GMT


> On Oct. 29, 2013, 4:35 a.m., Toshiaki Hatano wrote:
> >
> 
> Toshiaki Hatano wrote:
>     Actual issue is not "the physical interface name length must be shorter than 5" but
"generated bridge name cannot exceed 15 character".
>
> 
> Yoshikazu Nojima wrote:
>     If we check generated bridge name length, users will not face the exception before
their cloudstack environment grow up. They will face the exception in production environment
suddenly.
>     If we check physical interface name length, users can face the exception whenever
bridge name length is not enough.
>
> 
> Toshiaki Hatano wrote:
>     That's why we would note in document that such a situation can be happened when VXLAN
isolated zone grows up, isn't it? 
>     
>     It's too much to completely disable VXLAN isolation for pifName >=5, especially
when we won't provide any workaround.
>     IMO when we try to introduce fool proof mechanism, like this patch, we first try
to avoid creating restriction in non-fools' usage.
>     
>     Let's check Marcus's patch.
> 
> Yoshikazu Nojima wrote:
>     User can change a vlan interface name by configuration.
>     http://manpages.ubuntu.com/manpages/raring/man5/vlan-interfaces.5.html
>     
>     I think it is enough workaround. isn't it?

>From what I've tried in the past, given the Vlan tag 1000, you can implement that via
name "eth0.1000" or "vlan1000", but that's it. Unless something has changed, you can't create
an arbitrary short name. So that leaves only 3-4 characters for vni.

Ah, see set_name_type for vconfig, it describes these allowed names.


- Marcus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15001/#review27657
-----------------------------------------------------------


On Oct. 29, 2013, 12:51 a.m., Yoshikazu Nojima wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15001/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2013, 12:51 a.m.)
> 
> 
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
> 
> 
> Bugs: CLOUDSTACK-4967
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4967
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Guest network isn't created correctly when vxlan is used for isolation method, VNI is
bigger than 10000000, and physical network interface name length is longer than 4.
> This patch fix this issue by raising error when long interface name is specified.
> 
> Issue remained: document that physical interface name length must be shorter than 5.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
f945b74 
>   plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/15001/diff/
> 
> 
> Testing
> -------
> 
> I confirmed it passes the unit tests I add.
> 
> 
> Thanks,
> 
> Yoshikazu Nojima
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message