cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Duffy" <...@ianduffy.ie>
Subject Re: Review Request 14867: api call to import ldap users to the same domains in cloudstack
Date Tue, 29 Oct 2013 09:05:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14867/#review27669
-----------------------------------------------------------

Ship it!


Ship It!

- Ian Duffy


On Oct. 23, 2013, 5:26 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14867/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 5:26 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Ian Duffy.
> 
> 
> Bugs: CLOUDSTACK-4866
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4866
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added an api call to import all the ldap users to the same domains(ou's) in cloudstack
>     
>         TODO:
>         1. error handling of no domains present, nested hierarchy
>         2. handling the case when the api call fails for a specific user/users
>         3. test cases for LdapUserManager
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/user/DomainService.java 7c302e3 
>   client/tomcatconf/commands.properties.in 0296de0 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
PRE-CREATION 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java
9b21c8f 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
0cfb37c 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
87406ad 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUser.java 18ad7d9

>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java
7494346 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy
c593959 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapImportUsersCmdSpec.groovy
PRE-CREATION 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListUsersCmdSpec.groovy
5039443 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapManagerImplSpec.groovy
d681eac 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy
fce299d 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserResponseSpec.groovy
f1978fa 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy
8fd1ccc 
>   server/src/com/cloud/user/DomainManagerImpl.java b885c48 
>   server/test/com/cloud/user/MockDomainManagerImpl.java 616e12d 
> 
> Diff: https://reviews.apache.org/r/14867/diff/
> 
> 
> Testing
> -------
> 
> testing is done except for LdapUserManager(for which i am facing some issues locally)
and DomainService(for which no test cases exist currently)
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message