cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yoshikazu Nojima" <m...@ynojima.net>
Subject Re: Review Request 15001: CLOUDSTACK-4967: Bugfix: Guest network isn't created correctly in rare case when vxlan is used for isolation method
Date Tue, 29 Oct 2013 07:39:38 GMT


> On Oct. 29, 2013, 4:35 a.m., Toshiaki Hatano wrote:
> > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java,
line 158
> > <https://reviews.apache.org/r/15001/diff/2/?file=372880#file372880line158>
> >
> >     If we checked length here, generated brName should be checked, not a pifName.
> >     
> >     We shouldn't block valid brName by this check, e.g. eth0.1000-9000.
> 
> Toshiaki Hatano wrote:
>     s/eth0.1000-9000/breth0.100-9000/

It validates pifName, not brName. It validates pifName in the point of whether it is appropriate
to be used for generating bridge name here.


- Yoshikazu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15001/#review27657
-----------------------------------------------------------


On Oct. 29, 2013, 12:51 a.m., Yoshikazu Nojima wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15001/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2013, 12:51 a.m.)
> 
> 
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
> 
> 
> Bugs: CLOUDSTACK-4967
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4967
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Guest network isn't created correctly when vxlan is used for isolation method, VNI is
bigger than 10000000, and physical network interface name length is longer than 4.
> This patch fix this issue by raising error when long interface name is specified.
> 
> Issue remained: document that physical interface name length must be shorter than 5.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
f945b74 
>   plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/15001/diff/
> 
> 
> Testing
> -------
> 
> I confirmed it passes the unit tests I add.
> 
> 
> Thanks,
> 
> Yoshikazu Nojima
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message