cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Toshiaki Hatano" <hae...@haeena.net>
Subject Re: Review Request 15012: CLOUDSTACK-4984: decrement MAX_VXLAN_VNI to be aligned with Linux kernel
Date Tue, 29 Oct 2013 05:19:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15012/#review27660
-----------------------------------------------------------

Ship it!


Ship It!

- Toshiaki Hatano


On Oct. 29, 2013, 5 a.m., Yoshikazu Nojima wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15012/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2013, 5 a.m.)
> 
> 
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Linux vxlan interface doesn't accept VNI:16777215.
> https://github.com/torvalds/linux/blob/master/drivers/net/vxlan.c#L2140
> 
> As far as I read internet draft ( http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-05
),
> 16777215 is a valid VNI, but it cannot be used in Linux now.
> 
> This patch decrements MAX_VXLAN_VNI to 16777214.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkServiceImpl.java 61c070a 
> 
> Diff: https://reviews.apache.org/r/15012/diff/
> 
> 
> Testing
> -------
> 
> I confirmed VNI validation works by specifying 16777215-16777215 to id range via add
zone wizard.
> 
> 
> Thanks,
> 
> Yoshikazu Nojima
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message