cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yoshikazu Nojima" <m...@ynojima.net>
Subject Review Request 15001: CLOUDSTACK-4967: Bugfix: Guest network isn't created correctly in rare case when vxlan is used for isolation method
Date Tue, 29 Oct 2013 00:52:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15001/
-----------------------------------------------------------

Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.


Bugs: CLOUDSTACK-4967
    https://issues.apache.org/jira/browse/CLOUDSTACK-4967


Repository: cloudstack-git


Description
-------

Guest network isn't created correctly when vxlan is used for isolation method, VNI is bigger
than 10000000, and physical network interface name length is longer than 4.
This patch fix this issue by raising error when long interface name is specified.

Issue remained: document that physical interface name length must be shorter than 5.


Diffs
-----

  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f945b74

  plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/15001/diff/


Testing
-------

I confirmed it passes the unit tests I add.


Thanks,

Yoshikazu Nojima


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message