cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <...@apache.org>
Subject Re: Review Request 14925: Added few misc changes to marvin
Date Mon, 28 Oct 2013 07:21:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14925/#review27601
-----------------------------------------------------------

Ship it!


03830c5 -> master

Sorry to be an ass about this, but git summary needs improvements. Please also write down
the rationale of the changes you make. A simple listing of changed code, cleaned code is usually
not very clear about the changes and why they were made. 

- Prasanna Santhanam


On Oct. 25, 2013, 10:58 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14925/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2013, 10:58 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added few misc changes.
> Deleted some unwanted code.
> Few naming convention changes 
> Added a validateList utility function
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/codes.py 6099d88 
>   tools/marvin/marvin/configGenerator.py 50614c1 
>   tools/marvin/marvin/deployDataCenter.py f2dccdb 
>   tools/marvin/marvin/integration/lib/utils.py d81e80d 
>   tools/marvin/marvin/marvinPlugin.py 3b282e4 
> 
> Diff: https://reviews.apache.org/r/14925/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message