cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Prasanna Santhanam <...@apache.org>
Subject Re: Deploy systemvms broken on master
Date Thu, 24 Oct 2013 04:46:19 GMT
Is this a clean revert? I would revert the commit as it's blocked the
tests running on jenkins as well. 

On Wed, Oct 23, 2013 at 10:22:17PM +0000, SuichII, Christopher wrote:
> Bumping this as system vms still can?t be deployed on master.
> 
> -- 
> Chris Suich
> chris.suich@netapp.com
> NetApp Software Engineer
> Data Center Platforms ? Cloud Solutions
> Citrix, Cisco & Red Hat
> 
> On Oct 23, 2013, at 12:43 PM, SuichII, Christopher <Chris.Suich@netapp.com> wrote:
> 
> > Adding the commit author.
> > 
> > -- 
> > Chris Suich
> > chris.suich@netapp.com
> > NetApp Software Engineer
> > Data Center Platforms ? Cloud Solutions
> > Citrix, Cisco & Red Hat
> > 
> > On Oct 23, 2013, at 12:39 PM, SuichII, Christopher <Chris.Suich@netapp.com>
wrote:
> > 
> >> It appears that the deployment of systemvms was broken by commit e33ae74067d5d7ff165098028c0bd6897f14bbd2,
specifically, the change here<https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=server/src/com/cloud/hypervisor/HypervisorGuruBase.java;h=32c7693105261596a8ca489a8fc4cda93f252923;hp=2ee6364b231e6b7b0dc3d3acb2d16b7b061c748e;hb=e33ae74067d5d7ff165098028c0bd6897f14bbd2;hpb=aca6c420b40a411aebcc2eecad00e8341222348e>.
If the details are null, then you will get a NullPointerException on XenServer56FP1Resource.java
line 196 (as of commit 69b131fa1501ed7f6950a6dae4161efb659ad113):
> >> 
> >> Map<String, String> details = vmSpec.getDetails();
> >> ...
> >> String timeoffset = details.get("timeoffset?);
> >> 
> >> because vmSpec.getDetails() returns null.
> >> 
> >> -Chris
> >> --
> >> Chris Suich
> >> chris.suich@netapp.com<mailto:chris.suich@netapp.com>
> >> NetApp Software Engineer
> >> Data Center Platforms ? Cloud Solutions
> >> Citrix, Cisco & Red Hat
> >> 
> > 

-- 
Prasanna.,

------------------------
Powered by BigRock.com


Mime
View raw message