cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Syed Ahmed" <sah...@cloudops.com>
Subject Re: Review Request 14855: [Ssl Termination Support] Certificate managenemt interface
Date Wed, 23 Oct 2013 16:20:27 GMT


> On Oct. 22, 2013, 9:56 p.m., Darren Shepherd wrote:
> > engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapVO.java, line 31
> > <https://reviews.apache.org/r/14855/diff/1/?file=369304#file369304line31>
> >
> >     Their really should be a state field, not just a simple boolean flag for revoke.
 It will be easier to reliabily orchestrate if you have states.  Maybe different names, but
something like "Associating, Associated, Disassociating" and then the final disassociated
state is when you just delete the row

Is it OK if I include this change in my other patch? That whould provide a more complete usage
for the state flag. 


- Syed


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14855/#review27334
-----------------------------------------------------------


On Oct. 23, 2013, 4:17 p.m., Syed Ahmed wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14855/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 4:17 p.m.)
> 
> 
> Review request for cloudstack, Darren Shepherd, Murali Reddy, and Shengsheng Huang.
> 
> 
> Bugs: CLOUDSTACK-4821
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4821
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This is the first patch for Ssl termination support in Cloudstack. This patch is for
the certificate management. Basically uploading, validation, deletion, listing for the certificates.

> 
> The FS for this is at https://cwiki.apache.org/confluence/display/CLOUDSTACK/SSL+Termination+Support
. I will work on the second patch which will assign the certificates to loadbalancing rules.

> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/lb/CertService.java PRE-CREATION 
>   api/src/com/cloud/network/lb/SslCert.java PRE-CREATION 
>   api/src/org/apache/cloudstack/api/ApiConstants.java c75e6a0 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteSslCertCmd.java PRE-CREATION

>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListSslCertsCmd.java PRE-CREATION

>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/UploadSslCertCmd.java PRE-CREATION

>   api/src/org/apache/cloudstack/api/response/SslCertResponse.java PRE-CREATION 
>   client/tomcatconf/applicationContext.xml.in 2a3520b 
>   client/tomcatconf/componentContext.xml.in df5b002 
>   client/tomcatconf/nonossComponentContext.xml.in 9d1da95 
>   engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapDao.java PRE-CREATION 
>   engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapDaoImpl.java PRE-CREATION

>   engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapVO.java PRE-CREATION 
>   engine/schema/src/com/cloud/network/dao/SslCertDao.java PRE-CREATION 
>   engine/schema/src/com/cloud/network/dao/SslCertDaoImpl.java PRE-CREATION 
>   engine/schema/src/com/cloud/network/dao/SslCertVO.java PRE-CREATION 
>   plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
d63b14f 
>   server/src/com/cloud/server/ManagementServerImpl.java 699f469 
>   server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java PRE-CREATION 
>   server/test/org/apache/cloudstack/lb/ApplicationLoadBalancerTest.java 9b46e68 
>   server/test/org/apache/cloudstack/network/lb/ApplicationLoadBalancerTest.java PRE-CREATION

>   server/test/org/apache/cloudstack/network/lb/CertServiceTest.java PRE-CREATION 
>   server/test/resources/certs/bad_format_cert.crt PRE-CREATION 
>   server/test/resources/certs/dsa_self_signed.crt PRE-CREATION 
>   server/test/resources/certs/dsa_self_signed.key PRE-CREATION 
>   server/test/resources/certs/expired_cert.crt PRE-CREATION 
>   server/test/resources/certs/non_x509_pem.crt PRE-CREATION 
>   server/test/resources/certs/root_chain.crt PRE-CREATION 
>   server/test/resources/certs/rsa_ca_signed.crt PRE-CREATION 
>   server/test/resources/certs/rsa_ca_signed.key PRE-CREATION 
>   server/test/resources/certs/rsa_ca_signed2.crt PRE-CREATION 
>   server/test/resources/certs/rsa_ca_signed2.key PRE-CREATION 
>   server/test/resources/certs/rsa_random_pkey.key PRE-CREATION 
>   server/test/resources/certs/rsa_self_signed.crt PRE-CREATION 
>   server/test/resources/certs/rsa_self_signed.key PRE-CREATION 
>   server/test/resources/certs/rsa_self_signed_with_pwd.crt PRE-CREATION 
>   server/test/resources/certs/rsa_self_signed_with_pwd.key PRE-CREATION 
>   setup/db/db/schema-421to430.sql aaebf96 
> 
> Diff: https://reviews.apache.org/r/14855/diff/
> 
> 
> Testing
> -------
> 
> Unittests are done and included in the review. 
> 
> 
> Thanks,
> 
> Syed Ahmed
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message