cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <...@apache.org>
Subject Re: Review Request 14869: Added changes related to bug 4920 and few code clean up
Date Wed, 23 Oct 2013 08:24:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14869/#review27368
-----------------------------------------------------------

Ship it!


d4072c6 - master

- Prasanna Santhanam


On Oct. 23, 2013, 8:19 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14869/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 8:19 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 1. Currently, there was one issue found in requests library.
> 2. Added change to strip the command string passed to marvin request command
> 3. Removed few unwanted code.
> 4. Made the testclient uniform to pass both mgt and dbsrv details.
> 5. Fixed one issue in request call
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/cloudstackConnection.py df88fa2 
>   tools/marvin/marvin/cloudstackTestClient.py 5dcd8bf 
>   tools/marvin/marvin/codegenerator.py 96729f6 
>   tools/marvin/marvin/configGenerator.py 45c3d69 
>   tools/marvin/marvin/deployDataCenter.py 6b5f64b 
> 
> Diff: https://reviews.apache.org/r/14869/diff/
> 
> 
> Testing
> -------
> 
> Tested changes on simulator, it created entities post the run so it seems tests were
working fine.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message