cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Suich" <chris.su...@netapp.com>
Subject Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot
Date Tue, 22 Oct 2013 21:37:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14522/
-----------------------------------------------------------

(Updated Oct. 22, 2013, 9:37 p.m.)


Review request for cloudstack, Brian Federle, edison su, John Burwell, and Mike Tutkowski.


Changes
-------

Rebased and created a single patch file with all 4 commits.


Repository: cloudstack-git


Description
-------

After the last batch of work to the revertSnapshot API, SnapshotServiceImpl was not tied into
the workflow to be used by storage providers. I have added the logic in a similar fashion
to takeSnapshot(), backupSnapshot() and deleteSnapshot().

I have also added a 'Revert to Snapshot' action to the volume snapshots list in the UI.


Diffs
-----

  engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/DataMotionServiceImpl.java
2d31320 
  server/src/com/cloud/api/ApiResponseHelper.java 6978c9b 

Diff: https://reviews.apache.org/r/14522/diff/


Testing
-------

I have tested all of this locally with a custom storage provider.

Unfortunately, I'm still in the middle of figuring out how to properly unit test this type
of code. If anyone has any recommendations, please let me know.


File Attachments (updated)
----------------


  https://reviews.apache.org/media/uploaded/files/2013/10/22/commits.patch


Thanks,

Chris Suich


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message