cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <...@apache.org>
Subject Re: Review Request 14780: add netaddr package to the marvin dependency list
Date Tue, 22 Oct 2013 06:42:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14780/#review27281
-----------------------------------------------------------


I have a question: I know nothing within the framework actually uses `netaddr` but some of
the tests written using it do. Do you think we should add the dependencies of tests into marvin?
Or should we breakout the modules required off the tests separately?

- Prasanna Santhanam


On Oct. 21, 2013, 8:39 a.m., SrikanteswaraRao Talluri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14780/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2013, 8:39 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> add netaddr package to the marvin dependency list
> 
> 
> Diffs
> -----
> 
>   tools/marvin/setup.py eeed3bf 
> 
> Diff: https://reviews.apache.org/r/14780/diff/
> 
> 
> Testing
> -------
> 
> tested the marvin installation
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message