cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Aradhye" <gaurav.arad...@clogeny.com>
Subject Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding scale virtual machine test cases
Date Wed, 16 Oct 2013 12:08:22 GMT


> On Oct. 16, 2013, 2:59 p.m., SrikanteswaraRao Talluri wrote:
> > test/integration/component/test_scale_vm.py, line 98
> > <https://reviews.apache.org/r/14593/diff/2/?file=365062#file365062line98>
> >
> >     this is redundant, it is always better to get the mode populated when the test
is actually run. 
> >     you are already doing it with the following statement 
> >     cls.services["mode"] = cls.zone.networktype

Removed this statement. Passed networkType in mode parameter directly while creating Virtual
machine. It wasn't used anywhere else so not required to reassign the value.


- Gaurav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/#review27061
-----------------------------------------------------------


On Oct. 16, 2013, 5:38 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14593/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 5:38 p.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
> More tests to be added on top of this - in progress.
> 
> DDT library needed to run the test case.
> It can be installed with pip install ddt command.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_scale_vm.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py 0d52224 
>   tools/marvin/marvin/integration/lib/common.py 164ef20 
>   tools/marvin/setup.py eeed3bf 
> 
> Diff: https://reviews.apache.org/r/14593/diff/
> 
> 
> Testing
> -------
> 
> Tested on XenServer. Not attaching logs because different test cases were run at different
time, not all at once.
> All test cases running on XenServer, if at all needed, will add log after running them
once again.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message