cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Aradhye" <gaurav.arad...@clogeny.com>
Subject Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges
Date Tue, 15 Oct 2013 10:55:46 GMT


> On Oct. 15, 2013, 4:08 p.m., venkata swamy babu  budumuru wrote:
> > test/integration/component/test_non_contiguous_vlan.py, line 311
> > <https://reviews.apache.org/r/14319/diff/3/?file=359634#file359634line311>
> >
> >     I dont see this instructions and the steps mentioned in the doc string matches.
Can you please double check this test?

The test verifies that if the vlan id in a range is in use, then that vlan range can't be
removed.
The test updates the vlan with a range, deploys an instance so that it automatically creates
a network which uses a vlan id from the current range.
Then it tries to update vlan with different range (This is same as removing the current range).
It is checked that this operation should fail.

Please let me know which step is unclear so that I can update it with appropriate comment.


> On Oct. 15, 2013, 4:08 p.m., venkata swamy babu  budumuru wrote:
> > test/integration/component/test_non_contiguous_vlan.py, line 117
> > <https://reviews.apache.org/r/14319/diff/3/?file=359634#file359634line117>
> >
> >     1. Have something like "self.phy_network" instead of slf.network. This is little
confusing.
> >     
> >     2. This script is fetch phy network info here as well as in setNonContiguousVlanIds.
Can you remove the redundancy here?

Sure, will do.


- Gaurav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14319/#review27016
-----------------------------------------------------------


On Sept. 30, 2013, 1:51 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14319/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2013, 1:51 p.m.)
> 
> 
> Review request for cloudstack, Harikrishna Patnala, venkata swamy babu  budumuru, and
Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Adding Automation test cases for feature - Non Contiguous VLAN ranges
> CLOUDSTACk 2238.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_non_contiguous_vlan.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14319/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message