cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "venkata swamy babu budumuru" <venkataswamybabu.budum...@citrix.com>
Subject Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges
Date Tue, 15 Oct 2013 10:38:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14319/#review27016
-----------------------------------------------------------



test/integration/component/test_non_contiguous_vlan.py
<https://reviews.apache.org/r/14319/#comment52585>

    1. Have something like "self.phy_network" instead of slf.network. This is little confusing.
    
    2. This script is fetch phy network info here as well as in setNonContiguousVlanIds. Can
you remove the redundancy here?



test/integration/component/test_non_contiguous_vlan.py
<https://reviews.apache.org/r/14319/#comment52586>

    I dont see this instructions and the steps mentioned in the doc string matches. Can you
please double check this test?


- venkata swamy babu  budumuru


On Sept. 30, 2013, 8:21 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14319/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2013, 8:21 a.m.)
> 
> 
> Review request for cloudstack, Harikrishna Patnala, venkata swamy babu  budumuru, and
Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Adding Automation test cases for feature - Non Contiguous VLAN ranges
> CLOUDSTACk 2238.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_non_contiguous_vlan.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14319/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message