cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Saksham Srivastava" <saksham.srivast...@citrix.com>
Subject Review Request 14647: CLOUDSTACK-3583: Management server stop is not removing the PID
Date Tue, 15 Oct 2013 10:05:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14647/
-----------------------------------------------------------

Review request for cloudstack and Rajesh Battala.


Bugs: CLOUDSTACK-3583


Repository: cloudstack-git


Description
-------

The current implementation of #service cloudstack-management stop 
kills the process. The PID file and the lock file both continue to exist until the the service
is started again, which replaces them.
When the service has been stopped this causes #service cloudstack-management status to return
message like:
cloudstack-management dead but pid file exists 
The pid file locates at /var/run/cloudstack-management.pid and lock file at /var/lock/subsys/cloudstack-management.

Starting cloudstack-management will take care of them or you can manually clean up

In the fix I am removing the PID and the lock file once the service has been successfully
killed.
Also when the service is cleanly stopped the return value is 3, added the same check in handle_pid_file().


Diffs
-----

  packaging/centos63/cloud-management.rc 35f31b2 

Diff: https://reviews.apache.org/r/14647/diff/


Testing
-------

Tested locally :
The status is now as #service cloudstack-management status
cloudstack-management is stopped


Thanks,

Saksham Srivastava


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message