cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Suich" <>
Subject Re: Review Request 14577: Remove Setters from *JoinVO Classes
Date Mon, 14 Oct 2013 13:04:18 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 14, 2013, 1:04 p.m.)

Review request for cloudstack, Koushik Das, Mike Tutkowski, and Min Chen.


Added reviewers from discussion thread.

Repository: cloudstack-git


Removed setters from all *JoinVO classes as they represent MySQL views which are not editable.

The one exception to this was that I left setPassword(String) in UserVmJoinVO. This is because
the view does not actually have the user's password, but it is a field in UseVmJoinVO, so
it must be set manually, not auto-populated from the DB.


  server/src/com/cloud/api/query/vo/ fbcc934 
  server/src/com/cloud/api/query/vo/ ae63a8a 
  server/src/com/cloud/api/query/vo/ c45be1c 
  server/src/com/cloud/api/query/vo/ 6b1ddd6 
  server/src/com/cloud/api/query/vo/ c6a80e7 
  server/src/com/cloud/api/query/vo/ 58e8370 
  server/src/com/cloud/api/query/vo/ bfe4486 
  server/src/com/cloud/api/query/vo/ 12d7e5a 
  server/src/com/cloud/api/query/vo/ cf3cfdc 
  server/src/com/cloud/api/query/vo/ ac161af 
  server/src/com/cloud/api/query/vo/ 3fb4309 
  server/src/com/cloud/api/query/vo/ 1a8818a 
  server/src/com/cloud/api/query/vo/ f6e6760 
  server/src/com/cloud/api/query/vo/ 3885fa0 
  server/src/com/cloud/api/query/vo/ 9ce9555 
  server/src/com/cloud/api/query/vo/ 258b613 
  server/src/com/cloud/api/query/vo/ 05ff5f3 
  server/src/com/cloud/api/query/vo/ d98bb3b 
  server/src/com/cloud/api/query/vo/ bb1cfed 
  server/src/com/cloud/api/query/vo/ c44027b 
  server/src/com/cloud/api/query/vo/ 745db56 
  server/src/com/cloud/api/query/vo/ 9fe9fd1 



There were no compile errors after the deletions, so there shouldn't be any issues.

However, I did do a clean build and played around with the UI while watching vmops.log to
make sure there were no errors being thrown over this.


Chris Suich

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message