cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Damodar Reddy Talakanti" <damoder.re...@citrix.com>
Subject Review Request 14591: Fixng the issue of wrong netmask value is allowed in public traffic wizard while creating a zone
Date Fri, 11 Oct 2013 10:07:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14591/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4811


Repository: cloudstack-git


Description
-------

The UI Wizard was allowing Invalid CIDR in public traffic page while creating a zone and back
end was also not checking the correctness of the CIDR before creating a zone.


Diffs
-----

  server/src/com/cloud/configuration/ConfigurationManagerImpl.java b09b8ca 
  utils/pom.xml f4ac12b 
  utils/src/com/cloud/utils/net/NetUtils.java 05b485b 

Diff: https://reviews.apache.org/r/14591/diff/


Testing
-------

Testing is done through UI
For Example : Given wrong NetMask value 255.255.25.0 which is wrong net mask value
              Given Gateway as 10.147.30.1 and  NetMask as 255.255.255.192 and public IP Range
as 10.147.30.150-10.147.30.159..which is a wrong ip range for the given gateway and net mask
values.


Thanks,

Damodar Reddy Talakanti


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message