cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Suich" <chris.su...@netapp.com>
Subject Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot
Date Mon, 07 Oct 2013 20:26:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14522/
-----------------------------------------------------------

Review request for cloudstack, Brian Federle and edison su.


Repository: cloudstack-git


Description
-------

After the last batch of work to the revertSnapshot API, SnapshotServiceImpl was not tied into
the workflow to be used by storage providers. I have added the logic in a similar fashion
to takeSnapshot(), backupSnapshot() and deleteSnapshot().

I have also added a 'Revert to Snapshot' action to the volume snapshots list in the UI.


Diffs
-----

  api/src/org/apache/cloudstack/api/command/user/snapshot/RevertSnapshotCmd.java 946eebd 
  client/WEB-INF/classes/resources/messages.properties f92b85a 
  client/tomcatconf/commands.properties.in 58c770d 
  engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotServiceImpl.java
c09adca 
  server/src/com/cloud/server/ManagementServerImpl.java 0a0fcdc 
  server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java 0b53cfd 
  ui/dictionary.jsp f93f9dc 
  ui/scripts/storage.js 88fb9f2 

Diff: https://reviews.apache.org/r/14522/diff/


Testing
-------

I have tested all of this locally with a custom storage provider.

Unfortunately, I'm still in the middle of figuring out how to properly unit test this type
of code. If anyone has any recommendations, please let me know.


Thanks,

Chris Suich


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message