cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitin Mehta" <nitin.me...@citrix.com>
Subject Re: Review Request 14199: Adding missing test cases: Snapshots Improvement
Date Mon, 07 Oct 2013 17:19:39 GMT


> On Oct. 7, 2013, 5:18 p.m., Nitin Mehta wrote:
> >

It would be great if you could show logs of a sample run. Please also let me know if all the
5 cases are tested as well


- Nitin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/#review26715
-----------------------------------------------------------


On Sept. 18, 2013, 11:25 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14199/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, 11:25 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Adding 5 missing test cases.
> Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does
not exist now. Replaced it by "marvin_request". Checked running async jobs with this change.
Works correctly.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_snapshots_improvement.py PRE-CREATION 
>   tools/marvin/marvin/asyncJobMgr.py 25818a6 
> 
> Diff: https://reviews.apache.org/r/14199/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message