cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Hornyak" <laszlo.horn...@gmail.com>
Subject Review Request 14514: MacAddress cleanup and test
Date Sun, 06 Oct 2013 18:38:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14514/
-----------------------------------------------------------

Review request for cloudstack.


Repository: cloudstack-git


Description
-------

- main method removed since it was not used by any other code
- commonted-out code removed
- Formatter close added
- commons IOUtils to close resources - somewhat shorter than the try-catch block
- tests added


Diffs
-----

  utils/src/com/cloud/utils/net/MacAddress.java 15350c8 
  utils/test/com/cloud/utils/net/MacAddressTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/14514/diff/


Testing
-------

tests added


Thanks,

Laszlo Hornyak


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message