cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Darren Shepherd" <darren.s.sheph...@gmail.com>
Subject Re: Review Request 14290: KVMFencer cleanup
Date Fri, 04 Oct 2013 18:34:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14290/#review26687
-----------------------------------------------------------


I'm fine with dropping the methods that are not needed, but I don't see any reason to really
change fenceOff().  The changes seems to be more of a stylistic preference.  I feel both the
original and the changed code are just as readable, and each have the same basic characteristic.
 So the change for fenceOff() to me just seems like choosing one style over another.  Is there
a specific bug or issue that is address with your changes that I'm not noticing.

- Darren Shepherd


On Sept. 24, 2013, 7:51 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14290/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 7:51 p.m.)
> 
> 
> Review request for cloudstack, FrankXH FrankXH and Kelven Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> - start and stop removed, they do the same as the original method
> - host filtering logic moved to a the condition of the if statement
> - single default constructor removed
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/ha/KVMFencer.java 517209e 
> 
> Diff: https://reviews.apache.org/r/14290/diff/
> 
> 
> Testing
> -------
> 
> see https://reviews.apache.org/r/14289/
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message