cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Saksham Srivastava" <saksham.srivast...@citrix.com>
Subject Re: Review Request 14451: Some test for NetUtils
Date Thu, 03 Oct 2013 10:10:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14451/#review26645
-----------------------------------------------------------



utils/src/com/cloud/utils/net/NetUtils.java
<https://reviews.apache.org/r/14451/#comment51907>

    Can you mention against which branch the patch was created. Also create a bug/enhancement
in Jira to track the issue.



utils/src/com/cloud/utils/net/NetUtils.java
<https://reviews.apache.org/r/14451/#comment51905>

    Any particular reason for making dot as private static ? Making it local to ip2Long could
also solve the purpose as I don't see it being used anywhere else.
    If u still want to make it as private static it is better to keep the variable with all
other static variables at the beginning of the class.
    



utils/test/com/cloud/utils/net/NetUtilsTest.java
<https://reviews.apache.org/r/14451/#comment51906>

    Can you add few negative test cases like (15, "00:00:00:00:00:ff") in each of these methods.


- Saksham Srivastava


On Oct. 2, 2013, 9:19 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14451/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2013, 9:19 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> - tests added for mac2Long, byte2Mac, long2Mac, ip2Long and long2Ip
> - isWindows static method removed - it was not used
> - minor changes in the implementations of the tested methods
> 
> 
> Diffs
> -----
> 
>   utils/src/com/cloud/utils/net/NetUtils.java 1e72e22 
>   utils/test/com/cloud/utils/net/NetUtilsTest.java 3cfc98f 
> 
> Diff: https://reviews.apache.org/r/14451/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message