cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Hornyak" <laszlo.horn...@gmail.com>
Subject Re: Review Request 14405: ConstantTimeBackoff test and cleanup
Date Tue, 01 Oct 2013 17:32:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14405/
-----------------------------------------------------------

(Updated Oct. 1, 2013, 5:32 p.m.)


Review request for cloudstack.


Changes
-------

No stack trace logged in this version


Repository: cloudstack-git


Description
-------

- javadoc changed - the old one was copy-pasted from AgentShell
- start and stop method removed - they did the same as the overridden methods
- _counter removed as it was only written, but never read
- remove from _asleep map was moved to a finally block, to make sure it is removed even in
case of the thread gets interrupted
- Tests created for the above scenarios.


Diffs (updated)
-----

  agent/src/com/cloud/agent/AgentShell.java bf1e818 
  utils/src/com/cloud/utils/backoff/impl/ConstantTimeBackoff.java 976e369 
  utils/test/com/cloud/utils/backoff/impl/ConstantTimeBackoffTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/14405/diff/


Testing
-------

test included


Thanks,

Laszlo Hornyak


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message