Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Received-SPF: pass (nike.apache.org: domain of daan.hoogland@gmail.com
 designates 209.85.223.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAMCEDC1C8AHm9715WXzB1DKet0cs4i154_9EayHFJ70-6oaUGA@mail.gmail.com>
References: 
 <CAMCEDC16rgx+N7R66f2sakT-4RsiiUby_JP8xbjXUMy7KrT5FA@mail.gmail.com>
 <CAGQtxvbcPAHFpcPw-6z5_p23BgeEZDt6y_WKPr643Vif+vhALQ@mail.gmail.com>
 <CAMCEDC1C8AHm9715WXzB1DKet0cs4i154_9EayHFJ70-6oaUGA@mail.gmail.com>
From: Daan Hoogland <daan.hoogland@gmail.com>
Date: Wed, 25 Sep 2013 22:50:08 +0200
Message-ID: 
 <CAGQtxva2rhJK8sH_G73N2qyCPQMnnQugbuCQyeXfkRA6n6reWA@mail.gmail.com>
Subject: Re: bug? capacity not updated when adding memory to hypervisor
To: dev <dev@cloudstack.apache.org>
Content-Type: multipart/alternative; boundary=bcaec50e5ce74a7e6a04e73b670a

--bcaec50e5ce74a7e6a04e73b670a
Content-Type: text/plain; charset=ISO-8859-1

That would not seem in place in one of these blocks altogether, would it?


On Wed, Sep 25, 2013 at 10:45 PM, Darren Shepherd <
darren.s.shepherd@gmail.com> wrote:

> The main bug being the lack of
> memCap.setTotalCapacity(host.getTotalMemory());
>
> Darren
>
> On Wed, Sep 25, 2013 at 1:13 PM, Daan Hoogland <daan.hoogland@gmail.com>
> wrote:
> > I agree Darren,
> >
> > if (cpuCap.getUsedCapacity() == usedCpu &&
> > cpuCap.getReservedCapacity() == reservedCpu) {
> > } else {
> >    if (cpuCap.getReservedCapacity() != reservedCpu) {
> >                 cpuCap.setReservedCapacity(reservedCpu);
> >    }
> >    if (cpuCap.getUsedCapacity() != usedCpu) {
> >                 cpuCap.setUsedCapacity(usedCpu);
> >             }
> > }
> >
> > makes more sense. (same for mem)
> >
> >
> > On Wed, Sep 25, 2013 at 9:59 PM, Darren Shepherd <
> > darren.s.shepherd@gmail.com> wrote:
> >
> >> I added more memory to a hypervisor, and the host tables was updated
> >> properly, but the op_host_capacity is not updated.  I tracked down the
> >> code to CapacityManagerImpl.updateCapacityForHost.  The below logic
> >> seems completely wrong.  Unless I'm reading it wrong, it seems like it
> >> will only update EITHER used or reserved (not both) and never update
> >> total.  I removed log statements to make it more readable.
> >>
> >> if (cpuCap.getUsedCapacity() == usedCpu &&
> >> cpuCap.getReservedCapacity() == reservedCpu) {
> >>             } else if (cpuCap.getReservedCapacity() != reservedCpu) {
> >>                 cpuCap.setReservedCapacity(reservedCpu);
> >>             } else if (cpuCap.getUsedCapacity() != usedCpu) {
> >>                 cpuCap.setUsedCapacity(usedCpu);
> >>             }
> >>
> >>             if (memCap.getUsedCapacity() == usedMemory &&
> >> memCap.getReservedCapacity() == reservedMemory) {
> >>             } else if (memCap.getReservedCapacity() != reservedMemory) {
> >>                 memCap.setReservedCapacity(reservedMemory);
> >>             } else if (memCap.getUsedCapacity() != usedMemory) {
> >>                 memCap.setUsedCapacity(usedMemory);
> >>             }
> >>
>

--bcaec50e5ce74a7e6a04e73b670a--