Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5AA8C10A7B for ; Fri, 13 Sep 2013 16:20:22 +0000 (UTC) Received: (qmail 15392 invoked by uid 500); 13 Sep 2013 16:20:21 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 15321 invoked by uid 500); 13 Sep 2013 16:20:21 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 15310 invoked by uid 99); 13 Sep 2013 16:20:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Sep 2013 16:20:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F37A01D32BE; Fri, 13 Sep 2013 16:20:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0852801587013457107==" MIME-Version: 1.0 Subject: Re: Review Request 14126: Return name for getName() on LdapAuthenticator From: "Ian Duffy" To: "Donal Lafferty" Cc: "Darren Shepherd" , "Ian Duffy" , "cloudstack" Date: Fri, 13 Sep 2013 16:20:18 -0000 Message-ID: <20130913162018.8700.39046@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ian Duffy" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/14126/ X-Sender: "Ian Duffy" References: <20130913150609.8710.1597@reviews.apache.org> In-Reply-To: <20130913150609.8710.1597@reviews.apache.org> Reply-To: "Ian Duffy" --===============0852801587013457107== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14126/#review26081 ----------------------------------------------------------- Ship it! Ship It! - Ian Duffy On Sept. 13, 2013, 3:06 p.m., Darren Shepherd wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14126/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2013, 3:06 p.m.) > > > Review request for cloudstack and Donal Lafferty. > > > Repository: cloudstack-git > > > Description > ------- > > Currently getName() returns null, this patch just follows the style of the other authenticators in how they set and return their name. > > > Diffs > ----- > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java 559a979 > > Diff: https://reviews.apache.org/r/14126/diff/ > > > Testing > ------- > > > Thanks, > > Darren Shepherd > > --===============0852801587013457107==--