cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhinandan Prateek <Abhinandan.Prat...@citrix.com>
Subject Re: Q's about UserAuthenticators and getName()
Date Fri, 13 Sep 2013 10:48:18 GMT
The code already has the name set to ³LDAP² in 4.2. What branch are you on
?
Will also prefer if we can use getClass().getSimpleName() to get the
classname, but we should check the possibility of the adapter classnames
getting enhanced by underlying framework.



On 13/09/13 4:41 am, "Darren Shepherd" <darren.s.shepherd@gmail.com> wrote:

>DefaultUserAuthenticator masks the _name variable in
>ComponentLifecycleBase effectively making it so that no
>UserAuthenticator gets the default name of getClass().getSimpleName().
>
>Then each authenticator, except LDAP, does something like
>
>if (name == null) {
>   name = "MD5";
>}
>
>So instead of the default MD5UserAuthenticator it comes up with MD5 as
>its name.
>
>So my problem is that LDAP currently has a null name on getName().  So
>which should I do?  Add
>
>if (name == null) {
>   name = "LDAP";
>}
>
>Or remove the masked variable in DefaultUserAuthenticator such that all
>authenticators names will become the classname.  I just need it to be
>consistent for what I'm doing at the moment.  I'd personally prefer that
>they all just get the default name of getSimpleName().  But I don't know
>if there was some reason it was done this way.
>
>Darren


Mime
View raw message