cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject Re: Review Request 14167: [GSoC] Adding LB, PF service to GRE controller
Date Wed, 18 Sep 2013 09:08:32 GMT
h Nguyen,

It looks allright but I cannot judge this code without seeing it work. I
hope Hugo or Sebastien can approve it.

regards,
Daan


On Tue, Sep 17, 2013 at 12:04 PM, Nguyen Anh Tu <ng.tuna@gmail.com> wrote:

> Hi guys, I made an update patch, which aim to remove commented code and
> old files. Please review it
>
>
> 2013/9/17 tuna <ng.tuna@gmail.com>
>
>>    This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/14167/
>>
>> On September 17th, 2013, 8:24 a.m. UTC, *daan Hoogland* wrote:
>>
>> Do you have any (unit-)tests or #!human test scenarios to validate your code?
>>
>>  I haven't made unit tests yet. Will do asap. Just try with my own scenarios.
>>
>>
>> - tuna
>>
>> On September 17th, 2013, 3:03 a.m. UTC, tuna wrote:
>>   Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
>> By tuna.
>>
>> *Updated Sept. 17, 2013, 3:03 a.m.*
>>  *Repository: * cloudstack-git
>> Description
>>
>> I add a final patch for supporting L3 services (staticNAT, PortForwarding, LoadBalancing)
to GRE controller
>>
>>   Testing
>>
>> Testing done. I will make a screencast demo asap.
>>
>>   Diffs
>>
>>    - api/src/com/cloud/network/Network.java (aea496d)
>>    - api/src/com/cloud/network/Networks.java (5aede05)
>>    - api/src/org/apache/cloudstack/api/ResponseGenerator.java (b8ecef3)
>>    - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>>    (9741763)
>>    - plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java
>>    (3824669)
>>    - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java
>>    (6ad6e83)
>>    - scripts/vm/hypervisor/xenserver/ovstunnel (2b26ed6)
>>    - server/src/com/cloud/network/NetworkModelImpl.java (d7ca639)
>>    - server/src/com/cloud/network/element/VirtualRouterElement.java
>>    (ecf6473)
>>    - ui/scripts/system.js (18c3df4)
>>
>> View Diff <https://reviews.apache.org/r/14167/diff/>
>>
>
>
>
> --
>
> N.g.U.y.e.N.A.n.H.t.U
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message