cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Darren Shepherd" <darren.s.sheph...@gmail.com>
Subject Re: Review Request 14119: Default null value in ConfigKey results in NPE on second start
Date Mon, 30 Sep 2013 16:18:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14119/#review26491
-----------------------------------------------------------

Ship it!


Ship It!

- Darren Shepherd


On Sept. 13, 2013, 6:50 a.m., Darren Shepherd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14119/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 6:50 a.m.)
> 
> 
> Review request for cloudstack and Alex Huang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> If your ConfigKey has a default value, the second start of the mgmt server will result
in a NPE when comparing if the persisted default should be updated
> 
> java.lang.NullPointerException
> 	at org.apache.cloudstack.framework.config.impl.ConfigDepotImpl.populateConfigurations(ConfigDepotImpl.java:103)
> 	at com.cloud.server.ConfigurationServerImpl.persistDefaultValues(ConfigurationServerImpl.java:294)
> 	at com.cloud.server.ConfigurationServerImpl.configure(ConfigurationServerImpl.java:147)
> 
> 
> Diffs
> -----
> 
>   framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java
b516596 
> 
> Diff: https://reviews.apache.org/r/14119/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Darren Shepherd
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message