cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Darren Shepherd" <darren.s.sheph...@gmail.com>
Subject Re: Review Request 14360: Make getName() match the constant names for Network Capability, and Service
Date Sun, 29 Sep 2013 03:54:17 GMT


> On Sept. 27, 2013, 8:21 p.m., Alena Prokharchyk wrote:
> > Darren, changes in Network.java are going to break API compatibility as capabilities
parameters are used in createNetworkOffering API call (serviceCapabilitystList param). CS
UI and third party UI will get impacted as well.
> > If we have to change the name, its gotta be the capability parameter name, not its
name value.
> 
> daan Hoogland wrote:
>     This in turn, could have impact on other uses, like in a db could it?
>     
>     @Darren: you will need a lot more then just a (unit)test for the getname()
> 
> Alena Prokharchyk wrote:
>     Won't impact the DB as there is no direct ref between capability name and DB field
name /value.

I already discarded this.  I didn't realize the current string values are what we desire and
the Java constant names that are out of sync are really the "typos."  So I have no complaint
with the current implementation and changing the constant and all references to it would be
a waste of time.


- Darren


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14360/#review26447
-----------------------------------------------------------


On Sept. 27, 2013, 5:43 p.m., Darren Shepherd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14360/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2013, 5:43 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk and Chiradeep Vittal.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> VPCVirtualRouter is still left as inconsitent as changing that name will be impactful.
 The unit test checked in will still ensure that future providers match though
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/Network.java 49f380b 
>   api/test/com/cloud/network/NetworkTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14360/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Darren Shepherd
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message