cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Sorensen" <shadow...@gmail.com>
Subject Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand
Date Sat, 28 Sep 2013 06:43:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14381/
-----------------------------------------------------------

(Updated Sept. 28, 2013, 6:43 a.m.)


Review request for cloudstack, edison su and Mike Tutkowski.


Changes
-------

Fixed the TODO.


Repository: cloudstack-git


Description (updated)
-------

MigrateCommand: pass vmTO object so we can see which disks/storage pool types belong to the
vm when migrating a VM. This facilitates being able to call disconnectPhysicalDisksViaVmSpec

VirtualMachineManagerImpl: pass VirtualMachineTO when migrating so that we can see which disks
belong to the VM and what storage pools/adaptors should be used

LibvirtComputingResource: add calls KVMStoragePoolManager's connectPhysicalDiskViaVmSpec and
disconnectPhysicalDiskViaVmSpec calls where appropriate (when starting a vm, migrating a vm).
Ensure that we create 'raw' format XML disk definitions when the storage format is RAW. Move
cleanupDisk logic to storage adaptors so that each adaptor type can clean up its disks in
is own way.

KVMStoragePoolManager:  add connectPhysicalDisk, disconnectPhysicalDisk, connectPhysicalDiskViaVmSpec,
disconnectPhysicalDiskViaVmSpec. These all call the specific StorageAdaptor's connectPhysicalDisk
or disconnectPhysicalDisk calls.

KVMStorageProcessor: Call connectPhysicalDisk/disconnectPhysicalDisk on the storage adaptor.
Whether or not this is implemented is up to the storage adaptor.

LibvirtStorageAdaptor: implement dummy connectPhysicalDisk/disconnectPhysicalDisk, move cleanupDisk
logic from LibvirtComputingResource to disconnectPhysicalDiskByPath

StorageAdaptor: define connectPhysicalDisk/disconnectPhysicalDisk/disconnectPhysicalDiskByPath
in the interface


Diffs (updated)
-----

  core/src/com/cloud/agent/api/MigrateCommand.java 5042b8c 
  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
3ee811f 
  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java
e09c9ba 
  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java c69f9b0

  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
123a9f1 
  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/StorageAdaptor.java 4956d8d

  server/src/com/cloud/vm/VirtualMachineManagerImpl.java d46bbb0 

Diff: https://reviews.apache.org/r/14381/diff/


Testing
-------

Basic testing with my storage adaptor


Thanks,

Marcus Sorensen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message