cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Animesh Chaturvedi" <Animesh.Chaturv...@citrix.com>
Subject Re: Review Request 11981: Adding base support for NVP security groups to the NVP API
Date Wed, 25 Sep 2013 21:02:24 GMT


> On June 20, 2013, 6:40 a.m., Prasanna Santhanam wrote:
> > Minor nitpick : our code conventions recommend the method naming to not use underscore.
so it's lowerCaseAndNoUnderscores()
> > 
> > http://cloudstack.apache.org/develop/coding-conventions.html

Hugo can you review this patch


- Animesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11981/#review22157
-----------------------------------------------------------


On June 19, 2013, 9:28 p.m., Adrian Steer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11981/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 9:28 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This is initial version of API implementation of security groups within the NVP API
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitchPort.java
c571458 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraAddressPairs.java
PRE-CREATION 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraLogicalPortRule.java
PRE-CREATION 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java
12fa6c0 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraSecurityProfile.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/11981/diff/
> 
> 
> Testing
> -------
> 
> Compile testing
> 
> 
> Thanks,
> 
> Adrian Steer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message