cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 14231: Don't check implementation verion of Object for DatabaseUpgradeChecker
Date Tue, 24 Sep 2013 16:26:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14231/#review26355
-----------------------------------------------------------



engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java
<https://reviews.apache.org/r/14231/#comment51443>

    Could we check for an interface, allowing an ancestor between this and Object to supply
the version? your argument makes sense, your solution seems drastic given that womeone took
the trouble to write this code.


- daan Hoogland


On Sept. 19, 2013, 5:03 p.m., Darren Shepherd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14231/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2013, 5:03 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang and daan Hoogland.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Currently DatabaseUpgradeChecker determines the code version by doing this.getClass().getPackage().getImplementationVersion().
 If it can't find the version it will eventually just give up and not do the database check.
 The problem currently is if it doesn't find the version, it will also check its parent's
class version.  The parent is java.lang.Object which will return the java version (for example
1.6.0_43).  It doesn't seem like we would really want to ever try the JDK version as our code
version, so this patch it to just effectively remove that check.
>  
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java f001bf7 
> 
> Diff: https://reviews.apache.org/r/14231/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Darren Shepherd
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message