cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhinandan Prateek" <aprat...@apache.org>
Subject Re: Review Request 14148: Cleanup DefaultUserAuthenticator and removed masking _name variable
Date Wed, 18 Sep 2013 05:37:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14148/#review26209
-----------------------------------------------------------


In client/tomcatconf/applicationContext.xml.in we are referring passing name properties to
the authentication adapters e.g.:  

<bean id="LdapAuthenticator" class="org.apache.cloudstack.ldap.LdapAuthenticator">
    <property name="name" value="LDAP"/>
</bean>

There adapters never make use of this property. We should just remove the property from applicationContext.xml.in
too ?

- Abhinandan Prateek


On Sept. 16, 2013, 4:56 p.m., Darren Shepherd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14148/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2013, 4:56 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> DefaultUserAuthenticator maskes the _name varible in ComponentLifecycleBase making the
setName() method not work as expected.  This patch cleans up the code such that getName()
will be getClass().getSimpleName() unless overridden in the Spring configuration.
> 
> 
> Diffs
> -----
> 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
e62a3d8 
>   plugins/user-authenticators/md5/src/com/cloud/server/auth/MD5UserAuthenticator.java
e5b169f 
>   plugins/user-authenticators/plain-text/src/com/cloud/server/auth/PlainTextUserAuthenticator.java
f102275 
>   plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/SHA256SaltedUserAuthenticator.java
91be922 
>   server/src/com/cloud/server/auth/DefaultUserAuthenticator.java 952f724 
> 
> Diff: https://reviews.apache.org/r/14148/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Darren Shepherd
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message