cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 14167: [GSoC] Adding LB, PF service to GRE controller
Date Tue, 17 Sep 2013 08:24:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14167/#review26169
-----------------------------------------------------------



api/src/com/cloud/network/Networks.java
<https://reviews.apache.org/r/14167/#comment51130>

    Did you base this on an old version? please rebase your code so only the essentials of
your code remain.



plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
<https://reviews.apache.org/r/14167/#comment51129>

    can you remove the commented out code? It is still in git so there is no problem with
that



server/src/com/cloud/network/NetworkModelImpl.java
<https://reviews.apache.org/r/14167/#comment51131>

    remove code in comment, please.



server/src/com/cloud/network/element/VirtualRouterElement.java
<https://reviews.apache.org/r/14167/#comment51132>

    remove code in comment, please


Do you have any (unit-)tests or #!human test scenarios to validate your code?

- daan Hoogland


On Sept. 17, 2013, 3:03 a.m., tuna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14167/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2013, 3:03 a.m.)
> 
> 
> Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> I add a final patch for supporting L3 services (staticNAT, PortForwarding, LoadBalancing)
to GRE controller
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/Network.java aea496d 
>   api/src/com/cloud/network/Networks.java 5aede05 
>   api/src/org/apache/cloudstack/api/ResponseGenerator.java b8ecef3 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
9741763 
>   plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 3824669

>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java 6ad6e83

>   scripts/vm/hypervisor/xenserver/ovstunnel 2b26ed6 
>   server/src/com/cloud/network/NetworkModelImpl.java d7ca639 
>   server/src/com/cloud/network/element/VirtualRouterElement.java ecf6473 
>   ui/scripts/system.js 18c3df4 
> 
> Diff: https://reviews.apache.org/r/14167/diff/
> 
> 
> Testing
> -------
> 
> Testing done. I will make a screencast demo asap.
> 
> 
> Thanks,
> 
> tuna
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message