cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Duffy" <...@ianduffy.ie>
Subject Re: Review Request 14126: Return name for getName() on LdapAuthenticator
Date Fri, 13 Sep 2013 16:20:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14126/#review26081
-----------------------------------------------------------

Ship it!


Ship It!

- Ian Duffy


On Sept. 13, 2013, 3:06 p.m., Darren Shepherd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14126/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 3:06 p.m.)
> 
> 
> Review request for cloudstack and Donal Lafferty.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Currently getName() returns null, this patch just follows the style of the other authenticators
in how they set and return their name.
> 
> 
> Diffs
> -----
> 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
559a979 
> 
> Diff: https://reviews.apache.org/r/14126/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Darren Shepherd
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message