cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajesh Battala" <rajesh.batt...@citrix.com>
Subject Re: Review Request 13939: String join simplification
Date Tue, 03 Sep 2013 04:01:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13939/#review25844
-----------------------------------------------------------

Ship it!


API used will handle NULL iterator also..

Joins the elements of the provided Collection into a single String containing the provided
elements.
No delimiter is added before or after the list. Null objects or empty strings within the iteration
are represented by empty strings.

- Rajesh Battala


On Sept. 2, 2013, 10 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13939/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2013, 10 p.m.)
> 
> 
> Review request for cloudstack and David Nalley.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> - use commons-lang stringutils
> - added test to check compatibility
> 
> 
> Diffs
> -----
> 
>   utils/src/com/cloud/utils/StringUtils.java 948c0ac 
>   utils/test/com/cloud/utils/StringUtilsTest.java ae37c24 
> 
> Diff: https://reviews.apache.org/r/13939/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message