Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6D80B10B33 for ; Tue, 27 Aug 2013 10:47:52 +0000 (UTC) Received: (qmail 83810 invoked by uid 500); 27 Aug 2013 10:47:51 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 83780 invoked by uid 500); 27 Aug 2013 10:47:51 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 83770 invoked by uid 99); 27 Aug 2013 10:47:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Aug 2013 10:47:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 304D01D2C13; Tue, 27 Aug 2013 10:47:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3104310199675402051==" MIME-Version: 1.0 Subject: Re: Review Request 13807: we should not reserve memory and cpu for vmware VMs if the vmware.reserve.cpu and vmware.reserve.mem are set to false. From: "bharat kumar" To: "Nitin Mehta" Cc: "bharat kumar" , "cloudstack" Date: Tue, 27 Aug 2013 10:47:49 -0000 Message-ID: <20130827104749.16847.12573@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "bharat kumar" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/13807/ X-Sender: "bharat kumar" References: <20130827081725.16847.72051@reviews.apache.org> In-Reply-To: <20130827081725.16847.72051@reviews.apache.org> Reply-To: "bharat kumar" --===============3104310199675402051== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13807/ ----------------------------------------------------------- (Updated Aug. 27, 2013, 10:47 a.m.) Review request for cloudstack and Nitin Mehta. Bugs: Cloudstack-4498 Repository: cloudstack-git Description ------- https://issues.apache.org/jira/browse/CLOUDSTACK-4498 we should not reserve memory and cpu for vmware VMs if the vmware.reserve.cpu and vmware.reserve.mem are set to false. currently overcommit dose not honor the flag vmware.reserve.mem and vmware.reserve.cpu. Now we have fixed this and brought down these parameters to cluster level. Diffs (updated) ----- plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 8aae8c8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 4d24562 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 87e2e93 server/src/com/cloud/configuration/Config.java 1cc31b6 Diff: https://reviews.apache.org/r/13807/diff/ Testing ------- Tested on 4.2 Thanks, bharat kumar --===============3104310199675402051==--