Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 700471057D for ; Mon, 26 Aug 2013 14:30:22 +0000 (UTC) Received: (qmail 9612 invoked by uid 500); 26 Aug 2013 14:30:22 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 9464 invoked by uid 500); 26 Aug 2013 14:30:21 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 9454 invoked by uid 99); 26 Aug 2013 14:30:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Aug 2013 14:30:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2F6871D2B62; Mon, 26 Aug 2013 14:30:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6962216107883501886==" MIME-Version: 1.0 Subject: Review Request 13807: we should not reserve memory and cpu for vmware VMs if the vmware.reserve.cpu and vmware.reserve.mem are set to false. From: "bharat kumar" To: "Nitin Mehta" Cc: "bharat kumar" , "cloudstack" Date: Mon, 26 Aug 2013 14:30:19 -0000 Message-ID: <20130826143019.16846.88457@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "bharat kumar" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/13807/ X-Sender: "bharat kumar" Reply-To: "bharat kumar" --===============6962216107883501886== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13807/ ----------------------------------------------------------- Review request for cloudstack and Nitin Mehta. Bugs: Cloudstack-4498 Repository: cloudstack-git Description ------- https://issues.apache.org/jira/browse/CLOUDSTACK-4498 we should not reserve memory and cpu for vmware VMs if the vmware.reserve.cpu and vmware.reserve.mem are set to false. currently overcommit dose not honor the flag vmware.reserve.mem and vmware.reserve.cpu. Now we have fixed this and brought down these parameters to cluster level. Diffs ----- plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 8aae8c8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 4d24562 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 9cb6115 server/src/com/cloud/configuration/Config.java 8955087 vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java e545c8e Diff: https://reviews.apache.org/r/13807/diff/ Testing ------- Tested on 4.2 Thanks, bharat kumar --===============6962216107883501886==--