Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============7700112538398682943=="
MIME-Version: 1.0
Subject: Re: Review Request 13770: CLOUDSTACK-3363 UI > fix list Events/Alerts
 screen
 is in processing state forever with Delete Events/Alerts request having no
 filter
From: "Sanjay Tripathi" <sanjay.tripathi@citrix.com>
To: "bharat kumar" <bharat.kumar@citrix.com>,
 "Brian Federle" <brian.federle@citrix.com>
Cc: "Sanjay Tripathi" <sanjay.tripathi@citrix.com>,
 "bo wang" <bo_wang@tcloudcomputing.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Fri, 23 Aug 2013 11:51:46 -0000
Message-ID: <20130823115146.20071.14942@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sanjay Tripathi" <noreply@reviews.apache.org>
References: <20130823080854.20333.83538@reviews.apache.org>
In-Reply-To: <20130823080854.20333.83538@reviews.apache.org>
Reply-To: "Sanjay Tripathi" <sanjay.tripathi@citrix.com>

--===============7700112538398682943==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13770/#review25467
-----------------------------------------------------------


api/src/org/apache/cloudstack/api/command/admin/resource/DeleteAlertsCmd.java
<https://reviews.apache.org/r/13770/#comment49887>

    The API expects either of the three parameter i.e ids, type or enddate, so throwing the message appropriatly. For now, UI is not passing more than one ids (not implemented in UI.).
    
    So this change is not required.


api/src/org/apache/cloudstack/api/command/user/event/ArchiveEventsCmd.java
<https://reviews.apache.org/r/13770/#comment49888>

    This change is wrong and not required.


api/src/org/apache/cloudstack/api/command/user/event/DeleteEventsCmd.java
<https://reviews.apache.org/r/13770/#comment49889>

    This change is wrong and not required.


- Sanjay Tripathi


On Aug. 23, 2013, 8:08 a.m., bo wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13770/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2013, 8:08 a.m.)
> 
> 
> Review request for cloudstack, Brian Federle and bharat kumar.
> 
> 
> Bugs: CLOUDSTACK-3363
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 1.The loading screen won't disappear when delete the events or alerts with incorrect parameters ,Because there is no handling for exception in the js code.
> 2.Error messages are not completely correct, it should be "Either type or enddate must be specified".
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/admin/resource/DeleteAlertsCmd.java b0deaa9 
>   api/src/org/apache/cloudstack/api/command/user/event/ArchiveEventsCmd.java c5594e2 
>   api/src/org/apache/cloudstack/api/command/user/event/DeleteEventsCmd.java 548c2f3 
>   ui/scripts/events.js 46d45c0 
> 
> Diff: https://reviews.apache.org/r/13770/diff/
> 
> 
> Testing
> -------
> 
> 1.The loading screen will disappear when close the error message dialog.
> 2.The error message will be "Either type or enddate must be specified".
> 
> 
> Thanks,
> 
> bo wang
> 
>


--===============7700112538398682943==--