Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============2140266185790139120=="
MIME-Version: 1.0
Subject: Re: Review Request 13523: 7 New tests for affinity groups
From: "Ashutosh Kelkar" <ashutosh@clogeny.com>
To: "Girish Shilamkar" <girish@clogeny.com>,
 "Prasanna Santhanam" <tsp@apache.org>
Cc: "Ashutosh Kelkar" <ashutosh@clogeny.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Thu, 15 Aug 2013 04:48:02 -0000
Message-ID: <20130815044802.5632.115@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Ashutosh Kelkar" <noreply@reviews.apache.org>
References: <20130814144638.5632.66408@reviews.apache.org>
In-Reply-To: <20130814144638.5632.66408@reviews.apache.org>
Reply-To: "Ashutosh Kelkar" <ashutosh@clogeny.com>

--===============2140266185790139120==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On Aug. 14, 2013, 2:46 p.m., Prasanna Santhanam wrote:
> > test/integration/component/test_affinity_groups.py, line 507
> > <https://reviews.apache.org/r/13523/diff/1/?file=340307#file340307line507>
> >
> >     I didn't quite understand this assert. What hostid are we talking about?

The host id is from the VM we created and associated with the group. The test ensures the listing of the group also lists the host id of the vms associated with that affinity group. Updated the assert to better reflect the check being carried out.


> On Aug. 14, 2013, 2:46 p.m., Prasanna Santhanam wrote:
> > test/integration/component/test_affinity_groups.py, line 1594
> > <https://reviews.apache.org/r/13523/diff/1/?file=340307#file340307line1594>
> >
> >     Can we be explicit? 
> >     "Missing affinity group %s .."

Updated assert to make the check more clear


> On Aug. 14, 2013, 2:46 p.m., Prasanna Santhanam wrote:
> > test/integration/component/test_affinity_groups.py, line 1636
> > <https://reviews.apache.org/r/13523/diff/1/?file=340307#file340307line1636>
> >
> >     remove multihost tag

Dropped multihost tag from test


> On Aug. 14, 2013, 2:46 p.m., Prasanna Santhanam wrote:
> > test/integration/component/test_affinity_groups.py, line 1659
> > <https://reviews.apache.org/r/13523/diff/1/?file=340307#file340307line1659>
> >
> >     "%s affinity groups listed by admin with id %s. Expected 1" % (count, id)
> >     
> >     ^ This is much better for debugging and takes the form of expected against observed.

Updated assert to be inline with review comment


> On Aug. 14, 2013, 2:46 p.m., Prasanna Santhanam wrote:
> > test/integration/component/test_affinity_groups.py, line 1688
> > <https://reviews.apache.org/r/13523/diff/1/?file=340307#file340307line1688>
> >
> >     Improve the assertion to show expected vs observed.

Updated assert to be inline with review comment.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13523/#review25146
-----------------------------------------------------------


On Aug. 15, 2013, 4:41 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13523/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2013, 4:41 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> New tests for affinity groups
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_affinity_groups.py 39baf3e 
> 
> Diff: https://reviews.apache.org/r/13523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


--===============2140266185790139120==--