Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============7729283203130709381=="
MIME-Version: 1.0
Subject: Review Request 13534: Autoscaling: Deleting an isolated network of an
 account deletes also the autoscaling rule for a network associated with
 another account
From: "Rajesh Battala" <rajesh.battala@citrix.com>
To: "Ram Ganesh" <ram.ganesh@citrix.com>,
 "Vijay Venkatachalam" <vijay.venkatachalam@citrix.com>,
 "Murali Reddy" <muralimmreddy@gmail.com>,
 "Devdeep Singh" <devdeep.singh@citrix.com>
Cc: "Rajesh Battala" <rajesh.battala@citrix.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Tue, 13 Aug 2013 10:23:46 -0000
Message-ID: <20130813102346.5632.42970@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Rajesh Battala" <noreply@reviews.apache.org>
Reply-To: "Rajesh Battala" <rajesh.battala@citrix.com>

--===============7729283203130709381==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13534/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh, Murali Reddy, Ram Ganesh, and Vijay Venkatachalam.


Bugs: CLOUDSTACK-3369


Repository: cloudstack-git


Description
-------

issue:
if  autoscale policies are created by CS , then when any network gets deleted which got created with Netscaler as LB provider, the autoscale servers are getting deleted.

during delete the network ipassoc cmd executed on Netscaler resouce is cleaning up the services which are present in the same subnet. 
NetUtils.sameSubnet(vlanSelfIp, server.get_ipaddress(), vlanNetmask) is returning true for the autoscale servers even they are not present in the subnet because this method is returning true if any any of the ip is true.

autoscale server don't have ip address, so true is returned and hence removing the autoscale servers. which is causing severe issue for the autoscale policies created in cloudstack.

Fix:
====

while executing the method deleteServersInGuestVlan which will clean up the servers present in same subnet, check is made not to delete the autoscale servers.


Diffs
-----

  plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java e42a9ea 

Diff: https://reviews.apache.org/r/13534/diff/


Testing
-------

created accounts testa testb and created networks with NS as LB provider network offering.

1. In TestA, created autoscale policy and wait for deploy the instance. policy got created and vm got deployed.
2. Delete the testB network, check in ns.log that autoscale servers won't get delete.
3. in testB network, create LB rules, and delete the network, verified autoscale servers won't get delete.
4. Destroy testA, TestB network, first rules got cleaned up and then the ip assocations of the network are removed.


Thanks,

Rajesh Battala


--===============7729283203130709381==--